Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add defaultMessage example to README #1077

Closed
wants to merge 161 commits into from
Closed

docs: add defaultMessage example to README #1077

wants to merge 161 commits into from

Conversation

dsbert
Copy link

@dsbert dsbert commented May 13, 2021 •
edited
Loading

Description

Add defaultMessage example to README for custom validators. It was not initially clear to me that this is a supported feature and I had to dig through some closed issues to discover it.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

references: #56

dependabot bot added 30 commits March 23, 2021 17:40
@dependabot
build(deps-dev): bump ts-jest from 26.5.3 to 26.5.4 (typestack#985)
26e1525
@dependabot
build(deps): bump libphonenumber-js from 1.9.12 to 1.9.14 (typestack#984
8cc1bd7 
)
@dependabot
build(deps-dev): bump @typescript-eslint/eslint-plugin (typestack#981)
1505416
@dependabot
build(deps-dev): bump @types/jest from 26.0.20 to 26.0.21 (typestack#983
5d21e42 
)
@dependabot
build(deps-dev): bump eslint from 7.21.0 to 7.22.0 (typestack#986)
c611de9
@dependabot
build(deps-dev): bump @typescript-eslint/parser from 4.16.1 to 4.19.0 (…
82e9e67 
…typestack#982)
@dependabot
build(deps-dev): bump rollup from 2.42.3 to 2.42.4 (typestack#987)
f87ba6c
@dependabot
build(deps-dev): bump @types/jest from 26.0.21 to 26.0.22 (typestack#989
5b2910f 
)
@dependabot
build(deps-dev): bump @types/node from 14.14.35 to 14.14.36 (typestac…
5d05e67 
…k#990)
@dependabot
build(deps-dev): bump @rollup/plugin-node-resolve from 11.2.0 to 11.2…
25be325 
….1 (typestack#991)
@dependabot
build(deps-dev): bump @types/node from 14.14.36 to 14.14.37 (typestac…
0dcb0f2 
…k#992)
@dependabot
build(deps-dev): bump eslint from 7.22.0 to 7.23.0 (typestack#995)
2b5f354
@dependabot
build(deps-dev): bump rollup from 2.42.4 to 2.43.1 (typestack#994)
70fa7d2
@dependabot
build(deps-dev): bump @rollup/plugin-commonjs from 17.1.0 to 18.0.0 (t…
55ae9be 
…ypestack#993)
@dependabot
build(deps-dev): bump rollup from 2.43.1 to 2.44.0 (typestack#998)
1bd7b0d
@dependabot
build(deps-dev): bump @typescript-eslint/parser from 4.19.0 to 4.20.0 (…
c1b5094 
…typestack#999)
@dependabot
build(deps-dev): bump @typescript-eslint/eslint-plugin (typestack#1000)
dccbde8
@dependabot
build(deps): bump libphonenumber-js from 1.9.14 to 1.9.15 (typestack#…
615931e 
…1001)
@dependabot
build(deps-dev): bump eslint-plugin-jest from 24.3.2 to 24.3.4 (types…
0ecbd0f 
…tack#1004)
@dependabot
build(deps): bump libphonenumber-js from 1.9.15 to 1.9.16 (typestack#…
de0c673 
…1006)
@dependabot
build(deps-dev): bump @typescript-eslint/parser from 4.20.0 to 4.21.0 (…
dac243b 
…typestack#1007)
@dependabot
build(deps-dev): bump @typescript-eslint/eslint-plugin (typestack#1008)
1f612b5
@dependabot
build(deps-dev): bump typescript from 4.2.3 to 4.2.4 (typestack#1012)
3d668a6
@dependabot
build(deps-dev): bump rollup from 2.44.0 to 2.45.0 (typestack#1015)
88ae8d9
@dependabot
build(deps-dev): bump eslint-plugin-jest from 24.3.4 to 24.3.5 (types…
7a8b192 
…tack#1016)
@dependabot
build(deps-dev): bump eslint from 7.23.0 to 7.24.0 (typestack#1017)
3f5b7e2
@dependabot
build(deps-dev): bump rollup from 2.45.0 to 2.45.1 (typestack#1018)
75f6757
@dependabot
build(deps-dev): bump @typescript-eslint/parser from 4.21.0 to 4.22.0 (…
42842d8 
…typestack#1019)
@dependabot
build(deps-dev): bump rollup from 2.45.1 to 2.45.2 (typestack#1021)
29abff6
@dependabot
build(deps-dev): bump @typescript-eslint/eslint-plugin (typestack#1020)
4251428
dependabot bot added 22 commits March 7, 2022 09:03
@dependabot
build(deps-dev): bump rollup from 2.69.0 to 2.70.0 (typestack#1577)
176fb90
@dependabot
build(deps-dev): bump lint-staged from 12.3.4 to 12.3.5 (typestack#1576)
d721eb7
@dependabot
build(deps-dev): bump ts-node from 10.6.0 to 10.7.0 (typestack#1578)
77ef375
@dependabot
build(deps-dev): bump rollup from 2.70.0 to 2.70.1 (typestack#1582)
c72d1be
@dependabot
build(deps-dev): bump lint-staged from 12.3.5 to 12.3.6 (typestack#1584)
4d71476
@dependabot
build(deps-dev): bump prettier from 2.5.1 to 2.6.0 (typestack#1585)
7d8bd5f
@dependabot
build(deps): bump libphonenumber-js from 1.9.49 to 1.9.50 (typestack#…
303edfd 
…1589)
@dependabot
build(deps-dev): bump lint-staged from 12.3.6 to 12.3.7 (typestack#1590)
fd67e22
@dependabot
build(deps-dev): bump eslint-plugin-jest from 26.1.1 to 26.1.2 (types…
397473b 
…tack#1591)
@dependabot
build(deps-dev): bump @types/node from 17.0.21 to 17.0.22 (typestack#…
363a314 
…1592)
@dependabot
build(deps-dev): bump @types/node from 17.0.22 to 17.0.23 (typestack#…
4b0114d 
…1594)
@dependabot
build(deps): bump minimist from 1.2.5 to 1.2.6 (typestack#1595)
dc20354
@dependabot
build(deps-dev): bump typescript from 4.6.2 to 4.6.3 (typestack#1598)
0262804
@dependabot
build(deps-dev): bump prettier from 2.6.0 to 2.6.1 (typestack#1599)
e993a33
@dependabot
build(deps-dev): bump eslint-plugin-jest from 26.1.2 to 26.1.3 (types…
7098bf0 
…tack#1600)
@dependabot
build(deps-dev): bump @types/validator from 13.7.1 to 13.7.2 (typesta…
8927baa 
…ck#1602)
@dependabot
build(deps-dev): bump @rollup/plugin-commonjs from 21.0.2 to 21.0.3 (t…
b00838c 
…ypestack#1604)
@dependabot
build(deps-dev): bump prettier from 2.6.1 to 2.6.2 (typestack#1607)
ba43ec3
@dependabot
build(deps-dev): bump eslint-plugin-jest from 26.1.3 to 26.1.4 (types…
7befb18 
…tack#1613)
@dependabot
build(deps): bump libphonenumber-js from 1.9.50 to 1.9.51 (typestack#…
10eb3b2 
…1615)
@dependabot
build(deps-dev): bump @rollup/plugin-node-resolve from 13.1.3 to 13.2…
1dd1012 
….0 (typestack#1618)
@dependabot
build(deps-dev): bump @types/node from 17.0.23 to 17.0.24 (typestack#…
2ef8ff0 
…1619)
@braaar
Copy link
Member

braaar commented Oct 4, 2022

Hi @dsbert, could you rebase/merge this to get rid of irrelevant changes to package.json?

@braaar braaar mentioned this pull request Oct 4, 2022
Closed
@dsbert
Merge branch 'develop' into patch-1
856e3dd 
# Conflicts:
#	package-lock.json
#	package.json
@NoNameProvided
Copy link
Member

This is already included in the first custom decorator example. I agree this part of the docs can be improved, but probably in a more structured way.

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsbert @braaar @NoNameProvided